Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jackson-bom from 2.14.2 to 2.15.2 #964

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 5, 2023

Bumps jackson-bom from 2.14.2 to 2.15.2.

Commits
  • f630525 [maven-release-plugin] prepare release jackson-bom-2.15.2
  • cbb8d3c 2.15.2 release
  • 17e60d3 Back to snapshot dep
  • 2dfb8e3 [maven-release-plugin] prepare for next development iteration
  • eaff8b2 [maven-release-plugin] prepare release jackson-bom-2.15.1
  • 19ddbea Prepare for 2.15.1 release
  • 1c2c2fc Add version.plugin.moditect override to 1.0.0.Final
  • ccd5a3a Merge branch '2.14' into 2.15
  • 15b0965 Back to snapshot deps
  • 11c0403 [maven-release-plugin] prepare for next development iteration
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the type/dependencies Pull requests that update a dependency label Jun 5, 2023
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #964 (6a2e3ea) into main (d6276f9) will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #964      +/-   ##
============================================
+ Coverage     71.90%   71.96%   +0.05%     
  Complexity     1356     1356              
============================================
  Files           173      173              
  Lines          5011     5011              
  Branches        519      519              
============================================
+ Hits           3603     3606       +3     
+ Misses         1153     1152       -1     
+ Partials        255      253       -2     

see 2 files with indirect coverage changes

Bumps [jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.14.2 to 2.15.2.
- [Commits](FasterXML/jackson-bom@jackson-bom-2.14.2...jackson-bom-2.15.2)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson:jackson-bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/com.fasterxml.jackson-jackson-bom-2.15.2 branch from 034f352 to 6a2e3ea Compare June 5, 2023 09:36
@philsttr philsttr mentioned this pull request Jun 9, 2023
@pmancaux
Copy link

hello, did you know when you plan to do a release with this included?
perhaps they are a snapshot release that i can test?

thanks a lot!

@philsttr
Copy link
Collaborator

I haven't had much free time to work on logstash-logback-encoder recently. I'm not sure when I'll be able to release it.
No snapshots are available with this change. But you are more than welcome to clone the repo, build it with this change, and test it.

@pmancaux
Copy link

ok no problem, i will try to build my own and give you a feedback ;)

@pmancaux
Copy link

hi,

I have build your branch but i always have my problem with :

Caused by: java.lang.IllegalStateException: Logback configuration error detected: ERROR in net.logstash.logback.encoder.LoggingEventCompositeJsonEncoder@6e86842f - Error occurred while dynamically loading jackson modules java.util.ServiceConfigurationError: com.fasterxml.jackson.databind.Module: com.fasterxml.jackson.datatype.jsr310.JavaTimeModule not a subtype at org.springframework.boot.logging.logback.LogbackLoggingSystem.reportConfigurationErrorsIfNecessary(LogbackLoggingSystem.java:260)

I'dont know why.

My application work fine but if i activate an appender with logback-logstash-encoder i got this error.

If i comment encoder all work fine. My application is war generate by spring-boot 3.1.0, run under tomcat 10 and encoder is in tomcat/lib directory with logback-core-1.4.7.jar, all versions is now align

@philsttr
Copy link
Collaborator

philsttr commented Jun 17, 2023

Hi @pmancaux, I don't think that error is related to the jackson upgrade. The "not a subtype" error is generally caused by either A) the class isn't actually a subtype of the requested type or B) the classes are in different classloaders, perhaps different versions of the class are loaded by different loaders.

Since JavaTimeModule is the proper subtype, I'm going to guess that the error is caused by a classloader issue. You mention that some jars are in tomcat/lib. This means that some classes will be loaded via the classloader that loads classes from tomcat/lib, and other classes will be loaded by the classloader that loads jars from the war. Try to keep logstash-logback-encoder, logback, and jackson related jars in one classloader if possible. Either all in tomcat/lib or all inside the war. Don't split them between both locations.

@philsttr philsttr merged commit f65ce33 into main Jun 17, 2023
@philsttr philsttr deleted the dependabot/maven/com.fasterxml.jackson-jackson-bom-2.15.2 branch June 17, 2023 15:58
@brenuart
Copy link
Collaborator

@pmancaux Make sure you have all the Jackson libs at the same version...

@pmancaux
Copy link

Hi everyone, thanks for your answers.
I have all my jackson lib at the same version. Actually I am currently migrating my application from spring-5 to 6 and tomcat9 to 10. Before the migration everything was working fine but after there was this error so I am stuck because in tomcat9 I am deploying the same way and I had no classpath problem. I updated everything and the last thing I saw was that logback-logstash was not aligned with my jackson version so I thought that was the problem. but it seems not.
I'will try to do some other tests..

@brenuart
Copy link
Collaborator

As a hint I would compare my dependencies before/after... you will surely quickly spot the different ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/dependencies Pull requests that update a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants