Fix non-JSON generators (regression in 7.0) #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
non-JSON generators were broken in 7.0 when a call to generator.setRootValueSeparator was introduced. The non-JSON generators throw UnsupportedOperationException when setRootValueSeparator is invoked. Handle the UnsupportedOperationException properly. Also moved disabling the FLUSH_PASSED_TO_STREAM generator feature to prior to decoration, because the YAML generation needs this feature enabled to work properly. Introduced basic tests for non-JSON generators to catch the above problems in the future. Fixes #919
philsttr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
non-JSON generators were broken in 7.0 when a call to
generator.setRootValueSeparatorwas introduced. The non-JSON generators throwUnsupportedOperationExceptionwhensetRootValueSeparatoris invoked.Handle the
UnsupportedOperationExceptionproperly.Also moved disabling the
FLUSH_PASSED_TO_STREAMgenerator feature to prior to decoration, because the YAML generation needs this feature enabled to work properly.Introduced basic tests for non-JSON generators to catch the above problems in the future.
Fixes #919