Remove LogstashTcpSocketAppender.remoteHost/port

src/main/java/net/logstash/logback/appender/AbstractLogstashTcpSocketAppender.java

@@ -127,16 +127,6 @@ public abstract class AbstractLogstashTcpSocketAppender<Event extends DeferredPr
         SHUTDOWN_IN_PROGRESS_EXCEPTION.setStackTrace(new StackTraceElement[] {new StackTraceElement(AbstractLogstashTcpSocketAppender.TcpSendingEventHandler.class.getName(), "onEvent(..)", null, -1)});
     }
 
-    /**
-     * The host to which to connect and send events
-     */
-    private String remoteHost;
-
-    /**
-     * The TCP port on the host to which to connect and send events
-     */
-    private int port = DEFAULT_PORT;
-
     /**
      * Destinations to which to attempt to send logs, in order of preference.
      * <p>
@@ -908,27 +898,6 @@ public synchronized void start() {
             addError("No encoder was configured. Use <encoder> to specify the fully qualified class name of the encoder to use");
         }
 
-        /*
-         * Destinations can be configured via <remoteHost>/<port> OR <destination> but not both!
-         */
-        if (!destinations.isEmpty() && remoteHost != null) {
-            errorCount++;
-            addError("Use '<remoteHost>/<port>' or '<destination>' but not both");
-        }
-
-        /*
-         * Handle destination specified using <remoteHost>/<port>
-         */
-        if (remoteHost != null) {
-            addWarn("<remoteHost>/<port> are DEPRECATED, use <destination> instead");
-            try {
-                addDestinations(InetSocketAddress.createUnresolved(remoteHost, port));
-            } catch (IllegalArgumentException e) {
-                errorCount++;
-                addError(e.getMessage());
-            }
-        }
-
         /*
          * Make sure at least one destination has been specified
          */
@@ -1059,45 +1028,14 @@ public void setSocketFactory(SocketFactory socketFactory) {
         this.socketFactory = socketFactory;
     }
 
-    /**
-     * The host to which to connect and send events
-     *
-     * @deprecated use {@link #addDestination(String)} instead
-     */
-    @Deprecated
-    public void setRemoteHost(String host) {
-        remoteHost = host;
-    }
-
-    @Deprecated
-    public String getRemoteHost() {
-        return remoteHost;
-    }
-
-    /**
-     * The TCP port on the host to which to connect and send events
-     *
-     * @deprecated use {@link #addDestination(String)} instead
-     */
-    @Deprecated
-    public void setPort(int port) {
-        this.port = port;
-    }
-
-    @Deprecated
-    public int getPort() {
-        return port;
-    }
-
     /**
      * Adds the given destination (or destinations) to the list of potential destinations
      * to which to send logs.
      * <p>
      *
      * The string is a comma separated list of destinations in the form of hostName[:portNumber].
      * <p>
-     * If portNumber is not provided, then the configured {@link #port} will be used,
-     * which defaults to {@value #DEFAULT_PORT}
+     * If portNumber is not provided, then the default ({@value #DEFAULT_PORT}) will be used
      * <p>
      *
      * For example, "host1.domain.com,host2.domain.com:5560"

src/test/java/net/logstash/logback/appender/LogstashTcpSocketAppenderTest.java

@@ -575,22 +575,6 @@ public void testDestination_None() {
         Assertions.assertFalse(appender.isStarted());
     }
 
-
-    /**
-     * Specify destinations using both <remoteHost>/<port> and <destination>.
-     * Only one scheme can be used - make sure the appender refuses to start.
-     */
-    @Test
-    @SuppressWarnings("deprecation")
-    public void testDestination_MixedType() {
-        appender.setRemoteHost("localhost");
-        appender.setPort(10000);
-        appender.addDestination("localhost:10001");
-
-        appender.start();
-        Assertions.assertFalse(appender.isStarted());
-    }
-
     @Test
     public void testRoundRobin() throws Exception {
         appender.addDestination("localhost:10000");