Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump checkstyle to 8.44 (from 8.29) #547

Closed
brenuart opened this issue Jul 5, 2021 · 1 comment
Closed

Bump checkstyle to 8.44 (from 8.29) #547

brenuart opened this issue Jul 5, 2021 · 1 comment
Labels
type/enhancement
Milestone
7.0

Comments

@brenuart
Copy link
Collaborator

brenuart commented Jul 5, 2021

The maven-checkstyle-plugin complains with the following warning:

[INFO] --- maven-checkstyle-plugin:3.1.2:check (default) @ logstash-logback-encoder ---
[WARNING] Old version of checkstyle detected. Consider updating to >= v8.30
[WARNING] For more information see: https://maven.apache.org/plugins/maven-checkstyle-plugin/examples/upgrading-checkstyle.html

Plugin version 3.1.2 is using checkstyle 8.29 whereas the most recent version today is 8.44.
brenuart added a commit to brenuart/logstash-logback-encoder that referenced this issue Jul 5, 2021
@brenuart
Bump checkstyle to 8.44 (from 8.29)
fcba906 
Related issue: logfellow#547
@brenuart brenuart mentioned this issue Jul 5, 2021
Merged
@brenuart
Copy link
Collaborator Author

brenuart commented Jul 7, 2021

@philsttr This issue can be closed and corresponding milestone set

@philsttr philsttr added this to the 7.0 milestone Jul 7, 2021
@philsttr philsttr closed this as completed Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
7.0
Development

No branches or pull requests
2 participants
@brenuart @philsttr