Merge pull request #511 from ArthurGazizov/pre-sized-array

Avoid calling 'toArray' with pre-sized array argument
logfellow · Apr 19, 2021 · d20c337 · d20c337
2 parents 6c38c1d + 7bd5243
commit d20c337
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/main/java/net/logstash/logback/appender/AbstractLogstashTcpSocketAppender.java b/src/main/java/net/logstash/logback/appender/AbstractLogstashTcpSocketAppender.java
@@ -1106,7 +1106,7 @@ public void addDestination(final String destination) throws IllegalArgumentExcep
 
         List<InetSocketAddress> parsedDestinations = DestinationParser.parse(destination, DEFAULT_PORT);
 
-        addDestinations(parsedDestinations.toArray(new InetSocketAddress[parsedDestinations.size()]));
+        addDestinations(parsedDestinations.toArray(new InetSocketAddress[0]));
     }
 
     /**

diff --git a/src/main/java/net/logstash/logback/appender/AsyncDisruptorAppender.java b/src/main/java/net/logstash/logback/appender/AsyncDisruptorAppender.java
@@ -474,7 +474,7 @@ protected void prepareForDeferredProcessing(Event event) {
 
     protected String calculateThreadName() {
         List<Object> threadNameFormatParams = getThreadNameFormatParams();
-        return String.format(threadNameFormat, threadNameFormatParams.toArray(new Object[threadNameFormatParams.size()]));
+        return String.format(threadNameFormat, threadNameFormatParams.toArray());
     }
 
     protected List<Object> getThreadNameFormatParams() {
-Original file line number
+Diff line change
@@ Expand Up @@
             List<InetSocketAddress> parsedDestinations = DestinationParser.parse(destination, DEFAULT_PORT);
-            addDestinations(parsedDestinations.toArray(new InetSocketAddress[parsedDestinations.size()]));
+            addDestinations(parsedDestinations.toArray(new InetSocketAddress[0]));
         }
         /**
@@ Expand Down @@