Clean up pagination handling in Unified Data Table

[davismcphee]

Summary

This PR cleans up the pagination handling in Unified Data Table to make the logic easier to follow and less dependent on side effects.

[davismcphee]

Adding some notes related to the bug that was found.

[davismcphee]

Suggested change

	setCurrentPageIndex(pageIndex);
	onUpdatePageIndex?.(pageIndex);
	const calculatedPageIndex = pageIndex > pageCount - 1 ? 0 : pageIndex
	setCurrentPageIndex(calculatedPageIndex);
	onUpdatePageIndex?.(calculatedPageIndex);

I think this implementation could be updated to fix the bug you found by calculating the page index within this callback...

[logeekal]

@davismcphee , i do not think calculating there is needed, because onChangePage is not called when we need new pageIndex to be calculated. The other useEffect should be enough and i have included that.

[logeekal]

Also, I think onUpdatePageIndex should now be solely based on currentPageIndex. Any changes to that should be automatically trigger onUpdatePageIndex instead of calling onUpdatePageIndex at multiple places.

[davismcphee]

Suggested change

	pageIndex: currentPageIndex > pageCount - 1 ? 0 : currentPageIndex,
	pageIndex: currentPageIndex,

...Then passing currentPageIndex directly here.

And we'd only need to manually sync when pageCount changes in a separate effect:

useEffect(() => {
  setCurrentPageIndex((previousPageIndex) => {
    const calculatedPageIndex = previousPageIndex > pageCount - 1 ? 0 : previousPageIndex;

    if (calculatedPageIndex !== previousPageIndex) {
      onUpdatePageIndex?.(calculatedPageIndex);
    }

    return calculatedPageIndex;
  });
}, [onUpdatePageIndex, pageCount]);