remove autosave trigger

logeekal · Sep 26, 2023 · 3fe85bf · 3fe85bf
1 parent c439875
commit 3fe85bf
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 16 deletions.
diff --git a/...ins/security_solution/public/timelines/components/timeline/discover_tab_content/index.tsx b/...ins/security_solution/public/timelines/components/timeline/discover_tab_content/index.tsx
@@ -29,10 +29,7 @@ import { timelineSelectors } from '../../../store/timeline';
 import { useShallowEqualSelector } from '../../../../common/hooks/use_selector';
 import { timelineDefaults } from '../../../store/timeline/defaults';
 import { savedSearchComparator } from './utils';
-import {
-  triggerTimelineDiscoverAutoSave,
-  setIsDiscoverSavedSearchLoaded,
-} from '../../../store/timeline/actions';
+import { setIsDiscoverSavedSearchLoaded } from '../../../store/timeline/actions';
 import { GET_TIMELINE_DISCOVER_SAVED_SEARCH_TITLE } from './translations';
 
 const HideSearchSessionIndicatorBreadcrumbIcon = createGlobalStyle`
@@ -239,7 +236,6 @@ export const DiscoverTabContent: FC<DiscoverTabContentProps> = ({ timelineId })
       const unsubscribeState = stateContainer.appState.state$.subscribe({
         next: (state) => {
           setDiscoverAppState(state);
-          dispatch(triggerTimelineDiscoverAutoSave({ id: timelineId }));
         },
       });
 
@@ -261,7 +257,6 @@ export const DiscoverTabContent: FC<DiscoverTabContentProps> = ({ timelineId })
         .subscribe({
           next: () => {
             setDiscoverTimerange(discoverDataService.query.timefilter.timefilter.getTime());
-            dispatch(triggerTimelineDiscoverAutoSave({ id: timelineId }));
           },
         });
 
@@ -279,8 +274,6 @@ export const DiscoverTabContent: FC<DiscoverTabContentProps> = ({ timelineId })
       getAppStateFromSavedSearch,
       dataView,
       setDiscoverAppState,
-      dispatch,
-      timelineId,
       setDiscoverSavedSearchState,
     ]
   );

diff --git a/x-pack/plugins/security_solution/public/timelines/store/timeline/actions.ts b/x-pack/plugins/security_solution/public/timelines/store/timeline/actions.ts
@@ -280,11 +280,4 @@ export const updateSavedSearchId = actionCreator<{
 export const setIsDiscoverSavedSearchLoaded = actionCreator<{
   id: string;
   isDiscoverSavedSearchLoaded: boolean;
-}>('SET_IS_DISCOVER_SAVED_SEARCH_LOADED');
-
-/** To tie the discover state changes to timeline auto save, we use this action
- * to trigger the autosave logic managed here: x-pack/plugins/security_solution/public/timelines/store/timeline/epic.ts
- */
-export const triggerTimelineDiscoverAutoSave = actionCreator<{ id: string }>(
-  'TRIGGER_TIMELINE_DISCOVER_AUTO_SAVE'
-);
+}>('SET_IS_DISCOVER_SAVED_SEARCH_LOADED');