chore: explicit dependencies for integrations #4805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logaretm
force-pushed
the
main
branch
2 times, most recently
from
f52c150 to
52e18ad
Compare
|
I have not forgotten about this one, but we will need to hold off till valibot is fully released since this would promise a backward compatibility that doesn't exist in the current beta releases. I will update this PR myself once everything is a-ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔎 Overview
This PR eliminates the implicit dependency for developers on integration with a specific validator. Since the vee-validate integration directly depends on the validator in
dependencies, it is impossible to install a version higher or lower without duplication. The integration does not export the validator, so the developer needs to install it separately, leading to duplication and errors.We constantly monitor dependencies in our project, and running npm update caused dependency duplication whenever a patch version of the validator was released. Because of this, we had to specify "overrides" for the integration with our validator. Additionally, Eslint rules will complain if we do not specify the dependency in
dependencies.In any case, if the developer forgets to install the dependencies, npm will handle it starting from version 9.