-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field groups #4554
base: main
Are you sure you want to change the base?
Field groups #4554
Conversation
…alue, meta and errors
…iple nested fields, it allows to check if set of fields is dirty/touched/valid etc.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4554 +/- ##
==========================================
+ Coverage 89.81% 89.99% +0.17%
==========================================
Files 93 95 +2
Lines 7651 7855 +204
Branches 1345 1367 +22
==========================================
+ Hits 6872 7069 +197
- Misses 772 779 +7
Partials 7 7 ☔ View full report in Codecov by Sentry. |
After reverting docs package.json to state before recent version bumps I was able to run the documentation locally. Made some changes and labeled the |
b22d9ee
to
8e4c9ac
Compare
8e4c9ac
to
a9f758f
Compare
downgraded `remark-gfm` to lower version due to issue with building docs
Also downgraded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, I will need some time to think about this because I don't think such an API is warranted especially since we already encourage the composition API more than the components API which might deprecated in the future.
feat: added `checkChildFieldGroups` property to `FieldGroup`
fix: added types to `useFieldGroup` docs: added `useFieldGroup` documentation
@logaretm Extended the functionality by adding |
can be used with component and composition API now
Thanks, I will take a look when I can (around the weekend) |
component in `useFieldGroup` fix: search for field group in "self" too in `useField`
due to issue similar to watchEffect logaretm#3580
Any update on this ? Is it possible it will make it into the package ? Not sure if I should take my time to resolve conflicts and stuff :) |
# Conflicts: # docs/package.json # packages/vee-validate/src/Field.ts # packages/vee-validate/src/useField.ts # pnpm-lock.yaml
Hey @zaalbarxx, Unfortunately I have not had the time to check this out yet. This is a significant feature work and I would like to make sure we aggressively scope how this feature works because it caused problems before in the past:
So give me sometime to think about this some more, and sorry about the delay, I appreciate the time you've put into this. |
Any news on this? We would like to use groups too 🤞🏻 |
It does work on production for us, for over 3 months, if that matters anyhow. If you'd like to use it too @YoshiYo I released "patched" packages at
I had to release all of the packages since they depend on each other (like rules depend on validate), so patched versions also have their dependencies changed. The con is that you'd have to change all references in imports from |
f52c150
to
52e18ad
Compare
🔎 Overview
As detailed in #4181, it is extended version of PR #4553. This one, besides of exposing additional fields also adds new
FieldGroup
component with tests and documentation (documentation could not be verified since on my machine the documentation throws some errors🤓 Code snippets/examples (if applicable)
https://stackblitz.com/edit/vue-3-veevalidate-form-validation-example-1dlyi1?file=src%2Fvee-validate.esm.js,src%2Fmain.js,package.json,src%2FApp.vue
Here is the code snippet with
vee-validate.esm.js
built from the branch which shows how it actually works.✔ Issues affected
closes #4181
Also for some reason the builds are failing, I could get some assist here. But first of all, and most important question is if we will process with this PR ? :)