Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed GetStoredHostname from knowledge base #241 #2674

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

joachimmetz
Copy link
Member

@joachimmetz joachimmetz commented Jun 23, 2019

Removed GetStoredHostname from knowledge base #241

@joachimmetz joachimmetz requested a review from rgayon June 23, 2019 18:02
@joachimmetz joachimmetz added the blocked Work cannot progress until another issue is resolved label Jun 23, 2019
@joachimmetz joachimmetz mentioned this pull request Jun 23, 2019
12 tasks
@joachimmetz joachimmetz added this to the 2019 June release milestone Jun 23, 2019
@codecov
Copy link

codecov bot commented Jun 23, 2019

Codecov Report

Merging #2674 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2674      +/-   ##
==========================================
+ Coverage   86.22%   86.22%   +<.01%     
==========================================
  Files         478      478              
  Lines       32705    32715      +10     
==========================================
+ Hits        28199    28208       +9     
- Misses       4506     4507       +1
Impacted Files Coverage Δ
plaso/engine/knowledge_base.py 94.11% <100%> (+0.28%) ⬆️
plaso/storage/sqlite/sqlite_file.py 89.26% <100%> (+0.07%) ⬆️
plaso/output/mediator.py 54.28% <100%> (ø) ⬆️
plaso/analysis/interface.py 83.92% <0%> (-0.9%) ⬇️
plaso/engine/zeromq_queue.py 76.05% <0%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5157939...011e767. Read the comment docs.

@joachimmetz joachimmetz removed the blocked Work cannot progress until another issue is resolved label Jun 29, 2019
@joachimmetz joachimmetz merged commit 1bf6c54 into log2timeline:master Jul 2, 2019
@joachimmetz joachimmetz deleted the preproc1 branch July 2, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants