Exclude rancher managed annotation from ingress sync #2259
Merged
+98
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
neogopher
force-pushed
the
exclude-rancher-managed-annotation-ingress-sync
branch
from
fc4696f
to
752394e
Compare
neogopher
force-pushed
the
exclude-rancher-managed-annotation-ingress-sync
branch
from
752394e
to
2aacffe
Compare
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
FabianKramm
added a commit
that referenced
this pull request
Nov 13, 2024
[v0.20] feat: exclude Rancher managed annotations while syncing ingress (#2259)
FabianKramm
added a commit
that referenced
this pull request
Nov 13, 2024
[v0.19] feat: exclude Rancher managed annotations while syncing ingress (#2259)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-4976
Please provide a short message that should be published in the vcluster release notes
vcluster will now ignore updates to Rancher managed annotations when syncing ingress to & from the virtual cluster.
What else do we need to know?