chore: Update translate to patches #2198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.
|
rmweir
previously requested changes
Oct 4, 2024
rmweir
reviewed
Oct 4, 2024
There was a problem hiding this comment.
- I think everything prefixed with
Translatecan have that removed or swapped forPatch. - I think
EnableSwitchWithTranslateespecially need to be changed toEnabledSwitchWithPatch. - Patch can both be a noun and a verb but I don't think it should be both in a single sentence. I would prefer a description such as "Defines patches to be applied to resources." or "Defines patches for resources", as patches are usually used for one thing- patching.
How does that align with Go doc conventions? An example from the Go std lib: https://pkg.go.dev/io#Copy |
FabianKramm
approved these changes
Oct 7, 2024
ThomasK33
force-pushed
the
thomaskosiewski/eng-4775-update-translate-to-patches-for-the-yaml
branch
from
8c2b32e
to
17cf73d
Compare
Signed-off-by: Thomas Kosiewski <[email protected]>
ThomasK33
force-pushed
the
thomaskosiewski/eng-4775-update-translate-to-patches-for-the-yaml
branch
from
17cf73d
to
b0cf306
Compare
ThomasK33
deleted the
thomaskosiewski/eng-4775-update-translate-to-patches-for-the-yaml
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-4775
Please provide a short message that should be published in the vcluster release notes
Renamed translate field to patches
What else do we need to know?