Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): improve UX around vcluster upgrade command #2136

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

rohantmp
Copy link
Contributor

@rohantmp rohantmp commented Sep 12, 2024

part of ENG-4354

a continuation of #2131 with logging to give the user some guidance

screenshot:
image

image

Copy link

netlify bot commented Sep 12, 2024

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 6e00f0c
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/66e2719b02d56c0008681801

@rohantmp rohantmp changed the title fix(cli): do not upgrade if latest stable is older(eg: beta) fix(cli): improve UX around vcluster upgrade command Sep 12, 2024
@rohantmp
Copy link
Contributor Author

I don't think this requires a backport as it mainly affects unstable versions. Closed the backport PR

@FabianKramm FabianKramm merged commit 10d3d18 into loft-sh:main Sep 16, 2024
61 checks passed
@rohantmp rohantmp deleted the fixVersionCheck branch September 16, 2024 09:05
@deniseschannon deniseschannon added the backport-to-v0.20 backport this PR to v0.20 branch label Sep 19, 2024
@loft-bot
Copy link

💔 All backports failed

Status Branch Result
v0.20 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 2136

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v0.20 backport this PR to v0.20 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants