-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: coredns pod supports affinity and stain tolerance #2107
feat: coredns pod supports affinity and stain tolerance #2107
Conversation
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mayooot thanks for creating this PR! Can you add the changes to https://github.com/loft-sh/vcluster/blob/main/config/config.go and then run the script go run hack/schema/main.go
to generate the values.yaml and schema correctly? Also would be good if you can add a small helm unit test for your change, then I can merge it!
13c9078
to
5fc1505
Compare
@FabianKramm OK, I've updated config.go, and written a helm test case. This is the first time I've written a helm unit test, and since there are no test examples for affinity and tolerations in project, there may be errors, look coredns-configmap_test.yaml Another thing that confuses me is that after I modify config.go and run |
@mayooot thanks a lot! LGTM now, the only remaining issue is that you need to add your |
@FabianKramm ok, I'm done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I want to add tolerance and taint for coredns pod, I have verified it in the development environment but we are using v0.18.1 version of chart.