Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: coredns pod supports affinity and stain tolerance #2107

Merged

Conversation

mayooot
Copy link
Contributor

@mayooot mayooot commented Sep 3, 2024

I want to add tolerance and taint for coredns pod, I have verified it in the development environment but we are using v0.18.1 version of chart.

image image

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 16f462f
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/66e1141cc45b3400089e6117

Copy link
Member

@FabianKramm FabianKramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mayooot thanks for creating this PR! Can you add the changes to https://github.com/loft-sh/vcluster/blob/main/config/config.go and then run the script go run hack/schema/main.go to generate the values.yaml and schema correctly? Also would be good if you can add a small helm unit test for your change, then I can merge it!

@mayooot mayooot force-pushed the feat/coredns-support-affinity-and-toleration branch from 13c9078 to 5fc1505 Compare September 4, 2024 14:18
@mayooot
Copy link
Contributor Author

mayooot commented Sep 4, 2024

@mayooot thanks for creating this PR! Can you add the changes to https://github.com/loft-sh/vcluster/blob/main/config/config.go and then run the script go run hack/schema/main.go to generate the values.yaml and schema correctly? Also would be good if you can add a small helm unit test for your change, then I can merge it!

@FabianKramm OK, I've updated config.go, and written a helm test case.

This is the first time I've written a helm unit test, and since there are no test examples for affinity and tolerations in project, there may be errors, look coredns-configmap_test.yaml

Another thing that confuses me is that after I modify config.go and run go run hack/schema/main.go, values.schema.json has been changed, but values.yaml does not.

@FabianKramm
Copy link
Member

@mayooot thanks a lot! LGTM now, the only remaining issue is that you need to add your values.yaml changes to config/values.yaml as that will be used to generate chart/values.yaml.

@mayooot
Copy link
Contributor Author

mayooot commented Sep 11, 2024

@mayooot thanks a lot! LGTM now, the only remaining issue is that you need to add your values.yaml changes to config/values.yaml as that will be used to generate chart/values.yaml.

@FabianKramm ok, I'm done

Copy link
Member

@FabianKramm FabianKramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FabianKramm FabianKramm merged commit 6143e22 into loft-sh:main Sep 16, 2024
61 checks passed
@mayooot mayooot deleted the feat/coredns-support-affinity-and-toleration branch September 16, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants