Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add host name & namespace as annotations #2083

Merged
merged 4 commits into from
Aug 20, 2024

Conversation

FabianKramm
Copy link
Member

@FabianKramm FabianKramm commented Aug 20, 2024

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

Please provide a short message that should be published in the vcluster release notes

  • Adds vcluster.loft.sh/object-host-name and vcluster.loft.sh/object-host-namespace annotations to find out if a host object was copied. This is necessary for integrations where the controller in the host cluster can copy objects (e.g. KubeVirt's VirtualMachineClone), so we can identify based on these new annotations if the host object name actually matches the annotation.
  • Fixes an issue with vCluster service selector sync where translation was not correct
  • Moves try to translate back into the mapper
  • Only translate "release" label in single-namespace-mode

Copy link

netlify bot commented Aug 20, 2024

Deploy Preview for vcluster-docs canceled.

Name Link
🔨 Latest commit 76185ff
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/66c4c5f6072d7100089bce84

@FabianKramm FabianKramm merged commit 3bb7084 into loft-sh:main Aug 20, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant