Connect to vCluster Platform earlier #2029
Conversation
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
rmweir
force-pushed
the
external-db-shared
branch
from
792f073
to
003077d
Compare
| @@ -89,7 +89,12 @@ func ExecuteStart(ctx context.Context, options *StartOptions) error { | |||
| // set features for plugins to recognize | |||
| plugin.DefaultManager.SetProFeatures(pro.LicenseFeatures()) | |||
|
|
|||
| // check if we should create certs | |||
| // connect to vCluster platform if configured | |||
| startPlatformServersAndControllers, err := pro.ConnectToPlatform(ctx, vConfig) | |||
There was a problem hiding this comment.
Not a super fan of returning a function, but its okay I guess
There was a problem hiding this comment.
@FabianKramm I was not so sure about this myself. The reason why I chose to do it is because the start controller logic is highly dependent on dependencies created above it. Decoupling them would mean returning a handful of variables that I do not think makes sense from a reader's perspective, nor are they useful to other functions. It would also mean introducing a new pro function that I do not think is necessary. There are other solutions but I'm not convinced they are nicer than this. The server/controllers are related to ConnectToPlatform at least.
Another solution that I did consider was starting it in a go routine within ConnectToPlatform but blocking it with an empty channel, waitgroup, or some other sync mechanism, and then returning that. Do you think that would be better?
rmweir
force-pushed
the
external-db-shared
branch
2 times, most recently
from
72168bd
to
27388b6
Compare
rmweir
force-pushed
the
external-db-shared
branch
from
27388b6
to
6f242e7
Compare
rmweir
force-pushed
the
external-db-shared
branch
from
6f242e7
to
28545fa
Compare
rmweir
force-pushed
the
external-db-shared
branch
from
28545fa
to
5b71df9
Compare
vCluster is now able to request a data source from vCluster Platform. vCluster is only able to use the data source if it attempts to connect to the vCluster Platform prior to deploying its own control plane. vCluster Platform is now connected before control plane is deployed but the platform controllers and tailscale server are started after because they require the control plane to be running.
rmweir
force-pushed
the
external-db-shared
branch
2 times, most recently
from
f6f7a79
to
bdf6379
Compare
vCluster is now able to request a data source from vCluster Platform. vCluster is only able to use the data source if it attempts to connect to the vCluster Platform prior to deploying its own control plane. vCluster Platform is now connected before control plane is deployed but the platform controllers and tailscale server are started after because they require the control plane to be running.
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Part of ENG-4279
Part of enabling using the same database server credential for multiple vcluster datastores by creating new database and user, then returning credentials for the created database and user.
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster ...
What else do we need to know?