bugfix: do not output logs in vcluster connect if --print is set #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
hidalgopl
force-pushed
the
fix-vcluster-connect-with-print
branch
from
a4717f1
to
b56341c
Compare
FabianKramm
approved these changes
Aug 2, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
FabianKramm
added a commit
that referenced
this pull request
Aug 3, 2024
[v0.20] Merge pull request #2014 from hidalgopl/fix-vcluster-connect-with-print
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-4270
Fix replaces the
Logif--printflag is set. This new Log instance will log all non-error logs toio.Discard. Also, added two e2e tests:vcluster connect -n vcluster --print vclusterand writes it to temporary file, and then useskubectl --kubeconfig=<temporary-file> get pods -Ato check if outputed kubeconfig can be used to connect to virtual cluster.vcluster connect -n vcluster --print NOT_EXISTING_CLUSTER_NAMEstill outputs error.Please provide a short message that should be published in the vcluster release notes
Fixed an issue where
vcluster connect --printoutputs invalid kubeconfig (it included log)What else do we need to know?
I initially tried to construct
cobra.Commandinside the e2e test (as it is done here, but I couldn't direct the output of thecmd.Execute()to the temporary kubeconfig file (even usingcmd.SetOut(kubeCfgFile)). I believe reason for that is that we write toos.Stdoutdirectly here: https://github.com/hidalgopl/vcluster/blob/fix-vcluster-connect-with-print/pkg/cli/connect_helm.go#L154 (so we don't take into account theoutWriterfromcobra.Command.