-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for Adding tests for installing and deleting virtual cluster from kubectl #2013
Conversation
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
fb29b3c
to
95432c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test itself looks good, but the problem is that the e2e pipeline itself is creating a vcluster as well via the regular method, it seems to me you only want to install & delete via kubectl and not want to have that other vcluster created as well. You either need to adjust the e2e pipeline itself for this (.github/workflows/e2e.yaml) or need to create a separate pipeline.
a390f21
to
35ac965
Compare
e69b574
to
1999313
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tihnk whats weird is that we have all these different dimensions still for your new test. For what distros and dimensions do you want to run your test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sowmyav27 LGTM! Thanks for the PR!
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
What issue type does this pull request address? (keep at least one, remove the others)
/kind test
Details:
e2e.yaml
GHA workflow file.To-do in next PR
What does this pull request do?
Adds a test - install and delete vcluster using kubectl and helm
Please provide a short message that should be published in the vcluster release notes
N/A
What else do we need to know?