Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for Adding tests for installing and deleting virtual cluster from kubectl #2013

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

sowmyav27
Copy link

@sowmyav27 sowmyav27 commented Aug 1, 2024

What issue type does this pull request address? (keep at least one, remove the others)
/kind test

Details:

  • Implemented a module for running the install and delete commands for virtual cluster through helm and kubectl in the e2e.yaml GHA workflow file.
  • Added bash scripts for the actions - helm and kubectl

To-do in next PR

  • once this PR is merged - install and delete using argoCD and terraform

What does this pull request do?
Adds a test - install and delete vcluster using kubectl and helm

Please provide a short message that should be published in the vcluster release notes
N/A

What else do we need to know?

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for vcluster-docs canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit c83ae9c
🔍 Latest deploy log https://app.netlify.com/sites/vcluster-docs/deploys/66b1a4bd2d9d1800088fd591

@sowmyav27 sowmyav27 force-pushed the test-gha branch 5 times, most recently from fb29b3c to 95432c8 Compare August 1, 2024 22:14
@sowmyav27 sowmyav27 marked this pull request as ready for review August 1, 2024 23:31
@sowmyav27 sowmyav27 changed the title [DRAFT] Testing the GHA - PR for Adding tests for installing and deleting virtual cluster from kubectl PR for Adding tests for installing and deleting virtual cluster from kubectl Aug 1, 2024
Copy link
Member

@FabianKramm FabianKramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test itself looks good, but the problem is that the e2e pipeline itself is creating a vcluster as well via the regular method, it seems to me you only want to install & delete via kubectl and not want to have that other vcluster created as well. You either need to adjust the e2e pipeline itself for this (.github/workflows/e2e.yaml) or need to create a separate pipeline.

Copy link
Member

@FabianKramm FabianKramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tihnk whats weird is that we have all these different dimensions still for your new test. For what distros and dimensions do you want to run your test?

Copy link
Member

@FabianKramm FabianKramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sowmyav27 LGTM! Thanks for the PR!

@FabianKramm FabianKramm merged commit f2a395f into loft-sh:main Aug 6, 2024
58 checks passed
@sowmyav27 sowmyav27 added the backport-to-v0.20 backport this PR to v0.20 branch label Aug 7, 2024
@loft-bot
Copy link

loft-bot commented Aug 7, 2024

💚 All backports created successfully

Status Branch Result
v0.20

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v0.20 backport this PR to v0.20 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants