POD-779 | Initial integration of devpod-crane #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janekbaraniewski
force-pushed
the
POD-779/initial-integration-of-crane
branch
13 times, most recently
from
ef201c2
to
580d6df
Compare
janekbaraniewski
changed the title
janekbaraniewski
force-pushed
the
POD-779/initial-integration-of-crane
branch
from
580d6df
to
91dd848
Compare
janekbaraniewski
force-pushed
the
POD-779/initial-integration-of-crane
branch
from
91dd848
to
18d85e6
Compare
bkneis
reviewed
Aug 21, 2024
bkneis
reviewed
Aug 21, 2024
|
|
||
| GitCrane = "git" | ||
|
|
||
| BinPath = "devpod-crane" // FIXME |
There was a problem hiding this comment.
is this comment still valid?
There was a problem hiding this comment.
yeah would be nice to make it at least somehow configurable to support dev/debug binaries
bkneis
reviewed
Aug 21, 2024
bkneis
reviewed
Aug 21, 2024
bkneis
reviewed
Aug 21, 2024
bkneis
reviewed
Aug 21, 2024
bkneis
reviewed
Aug 21, 2024
| } | ||
|
|
||
| if language.MapConfig[lang] == nil { |
There was a problem hiding this comment.
I think we need to check the key exits first
if _, ok := language.MapConfig[lang]; ok {}
There was a problem hiding this comment.
yeah definitely. didn't really go into this code yet, tried to break it down a bit to make it easier to refactor.
pkg/devcontainer/run.go
Outdated
| return options.Recreate && !isDockerDriver | ||
| } | ||
|
|
||
| func (r *runner) getRawConfig(options provider2.CLIOptions) (*config.DevContainerConfig, error) { | ||
| if r.WorkspaceConfig.Workspace.DevContainerConfig != nil { |
There was a problem hiding this comment.
this if else if else if block is a little hard to read. Since we have early returns in each block can we separate into separate if statements?
pkg/devcontainer/run.go
Outdated
| // will be gracefully handled by the auto-detection mechanism | ||
| if err != nil && !os.IsNotExist(err) { | ||
| return nil, errors.Wrap(err, "parsing devcontainer.json") | ||
| } else if rawParsedConfig == nil { |
There was a problem hiding this comment.
else if can be replaced here with separate if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of POD-779