Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POD-769: Check build target exists in Dockerfile #1218

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

bkneis
Copy link
Contributor

@bkneis bkneis commented Aug 13, 2024

This PR fixes an issue a user had due to them specifying a build target in devcontainer.json that was not present in the Dockerfile. This PR solves the issue by validating the Dockerfile before deploying.

@bkneis bkneis marked this pull request as draft August 13, 2024 16:42
@bkneis bkneis marked this pull request as ready for review August 14, 2024 12:31
@pascalbreuninger pascalbreuninger merged commit c9501dd into loft-sh:main Aug 14, 2024
24 of 25 checks passed
@bkneis bkneis deleted the POD-769/check-target branch August 14, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants