Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uiManager can be nil #37

Closed
wants to merge 1 commit into from
Closed

fix: uiManager can be nil #37

wants to merge 1 commit into from

Conversation

hirbod
Copy link
Contributor

@hirbod hirbod commented Jun 10, 2024

I talked with Tomasz from Expo and he said that uiManager can be nil too, so it was fine in the first place.

Copy link

vercel bot commented Jun 10, 2024

@hirbod is attempting to deploy a commit to the Jovanni's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codeclimate bot commented Jun 10, 2024

Code Climate has analyzed commit b8d79c5 and detected 0 issues on this pull request.

View more on Code Climate.

@lodev09
Copy link
Owner

lodev09 commented Jun 10, 2024

Screenshot 2024-06-11 at 04 02 20

Not sure if ? will help though... it could still crash if this becomes nil?

@lodev09
Copy link
Owner

lodev09 commented Jun 10, 2024

I'd say we stick to the type provided by RN. if it crashes, then there's definitely something else going on and might help dev to debug.

@hirbod hirbod closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants