feat: add initialIndex & onMount props
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lodev09
changed the title
initialIndex & onLoad propsinitialIndex & onReady props
lodev09
changed the title
initialIndex & onReady propsinitialIndex & onMount props
|
Code Climate has analyzed commit 6fa2bd0 and detected 0 issues on this pull request. View more on Code Climate. |
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
hirbod
approved these changes
Jun 9, 2024
There was a problem hiding this comment.
Hey @lodev09, I tested it thoroughly. It definitely feels snappier and faster now. Hopefully, we can get a faster easing function in a future release, but this works great for now. The auto height calculation also seems more accurate.
LGTM
Tested with and without animation, and also multiple stacks. I'll just need to adjust my paddings now, but thats fine, because its much more accurate and predictable now!
testindex.mp4
|
🚀 This pull request is included in v0.12.0. See Release 0.12.0 for release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initialIndexprop to present the sheet after loading.onMountevent prop to allow presenting sheet after loading.Fixes #28