Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

divBig:replace push_back to emplace_back #367

Merged
merged 1 commit into from
Jan 5, 2025
Merged

divBig:replace push_back to emplace_back #367

merged 1 commit into from
Jan 5, 2025

Conversation

helpau
Copy link
Contributor

@helpau helpau commented Jan 5, 2025 •
edited
Loading

@helpau helpau requested a review from ckrause as a code owner January 5, 2025 15:40
ckrause
ckrause approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@ckrause ckrause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ckrause ckrause merged commit 1c20579 into loda-lang:main Jan 5, 2025
5 checks passed
@helpau helpau deleted the embrace_back_division branch January 6, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckrause ckrause ckrause approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@helpau @ckrause