Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update github actions to get rid of deprecation warnings #2778

Closed
wants to merge 3 commits into from

Conversation

mgor
Copy link
Contributor

@mgor mgor commented Jun 27, 2024

update versions to get rid of:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-python@v4, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

also includes actions/setup-node@v3 and borales/actions-yarn@v3

with actions/cache@v3 on windows image there would be an error, but the step wouldn't fail:

[Windows](https://github.com/mgor/locust/actions/runs/9692188762/job/26745040620#step:6:14)
Input required and not supplied: path

when updating to actions/cache@v4 the step would also fail. to fix this the shell for the steps that redirects output to $GITHUB_{OUTPUT,ENV} was set to bash. since the default shell for windows runners is powershell, and echo ... >> ... isn't crossplatform compatible, and bash is available on the windows images.

mgor added 3 commits June 27, 2024 09:58
update to next version of github actions to get of deprecation warnings during workflow runs.
`>>` is not crossplatform, and would fail on windows, which uses powershell.
@mgor
Copy link
Contributor Author

mgor commented Jun 27, 2024

not sure why py39 fails in print stats tests... saw that once in my other PR as well, but re-running it and it passed. doesn't seems like i have permission to re-run jobs though.

@cyberw
Copy link
Collaborator

cyberw commented Jun 27, 2024

I re-ran it now. Is it always 3.9? I was already eager to drop 3.9 support to use nice language features that were introduced in 3.10 :P

But I might not want to merge this right now - #2725 is quite a big change and I'd rather not make two changes in the build in the same release. For this reason I'm putting it in draft for now. Or is it urgent for you?

@cyberw cyberw marked this pull request as draft June 27, 2024 09:32
@mgor
Copy link
Contributor Author

mgor commented Jun 27, 2024

the two times i've seen it fail it was py39, doesn't really have any good statistics for it :)

no, not urgent at all, it's just that i hate warning/errors and wanted it fixed ;) so that's fine

@cyberw
Copy link
Collaborator

cyberw commented Aug 2, 2024

I'd love to do this update now! Want to update your PR?

@cyberw
Copy link
Collaborator

cyberw commented Aug 15, 2024

I made a separate PR myself, but thanks for poking me with this :)

@mgor
Copy link
Contributor Author

mgor commented Aug 15, 2024

Ops, sorry I missed your comment from two weeks ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants