Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Report][Modern-UI] HTML report is blank #2609

Merged
merged 3 commits into from
Feb 22, 2024
Merged

[Report][Modern-UI] HTML report is blank #2609

merged 3 commits into from
Feb 22, 2024

Conversation

andrewbaldwin44
Copy link
Collaborator

@andrewbaldwin44 andrewbaldwin44 commented Feb 22, 2024 •
edited
Loading

Fixes #2603

Proposal

  • I managed to get an error message that stated the API middleware was not properly setup, so I added react toolkits API middleware to the redux store
  • Added an ErrorBoundary, which will allow us to catch any exceptions should they occur and then create an issue
    image
  • I needed to check that the auth page was still working as expected and I fixed the example

@cyberw
Copy link
Collaborator

cyberw commented Feb 22, 2024

nice! is this something we could/should unit test?

@andrewbaldwin44
Copy link
Collaborator Author

andrewbaldwin44 commented Feb 22, 2024 •
edited
Loading

Tests are added in this PR

@cyberw cyberw merged commit 6ce340b into locustio:master Feb 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Report][Modern-UI] HTML report is blank
2 participants
@andrewbaldwin44 @cyberw