FastResponse: Detect response text encoding when no information is present on the response headers. #2485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sponse encoding, use charset_normalizer.detect to detect the encoding from response content bytes
2 tasks
|
I like this one the best, because it matches python-requests. Can you fix the typing issue? The regular tests are unstable at the moment, feel free to ignore that... |
… Any, None]"; expected "str"
|
Thank you for accepting this. We will integrate it in our framework as soon as it is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no response headers are present or do not contain response encoding, use charset_normalizer.detect to detect the encoding from response content bytes.