Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with --stop timeout parsing time strings #2239

Merged
merged 10 commits into from
Oct 28, 2022
Merged

Fix issue with --stop timeout parsing time strings #2239

merged 10 commits into from
Oct 28, 2022

Commits on Oct 26, 2022

  1. Test --stop-timeout

    @cyberw
    cyberw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    7a7f3fd View commit details
    Browse the repository at this point in the history

  2. read stop_timeout from parsed options instead of directly from enviro… 

    …nment.
    @cyberw
    cyberw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    b3d26fd View commit details
    Browse the repository at this point in the history

  3. black

    @cyberw
    cyberw committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    e1f4354 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Go back to reading stop_timeout directly from environment instead of … 

    …parsed_options.stop_timeout
    @cyberw
    cyberw committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    bd2fd96 View commit details
    Browse the repository at this point in the history

  2. options.stop_timeout is now a string, not an int

    @cyberw
    cyberw committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    6531dea View commit details
    Browse the repository at this point in the history

  3. Improve test_main to show more relevant info on fail.

    @cyberw
    cyberw committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    a1c1b3a View commit details
    Browse the repository at this point in the history

  4. Parse options.stop_timeout earlier in main.py

    @cyberw
    cyberw committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    9ad4be8 View commit details
    Browse the repository at this point in the history

  5. unit test invalid stop_timeout string

    @cyberw
    cyberw committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    db39fcd View commit details
    Browse the repository at this point in the history

  6. Python 3.11 is now released, so use py311 instead of py311-dev when t… 

    …esting.
    @cyberw
    cyberw committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    f24afd2 View commit details
    Browse the repository at this point in the history

  7. remove unnecessary None guard

    @cyberw
    cyberw committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    357057f View commit details
    Browse the repository at this point in the history