print_stats table width fix for #2084 #2088
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the width of the
print_stats
table was increased in a previous PR, which resulted in line wraps in terminal sizes that previously didn't have it (see discussion in #2084).this PR tries to solve that. in the case of a big terminal window causing
STATS_NAME_WIDTH
to be at max 80 characters, the table is now 1 character less wide than the original implementation (before #2084), 159 columns vs 158 columns.this is an comparision of the output of the tables with this PR and the original implementation with a 119 column wide terminal:
the original implementation would allow a request name of maximum 34 characters in the
DELETE
request type case, and 37 characters in theGET
request type case.with the new implementation, the maximum request name length, with 119 columns, would always be 32 characters.