Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove step load feature #1584

Merged
merged 3 commits into from
Oct 12, 2020
Merged

Remove step load feature #1584

merged 3 commits into from
Oct 12, 2020

Conversation

max-rocket-internet
Copy link
Contributor

Resolves #1575

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #1584 into master will increase coverage by 1.25%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1584      +/-   ##
==========================================
+ Coverage   81.58%   82.83%   +1.25%     
==========================================
  Files          28       28              
  Lines        2601     2558      -43     
  Branches      397      388       -9     
==========================================
- Hits         2122     2119       -3     
+ Misses        379      342      -37     
+ Partials      100       97       -3     
Impacted Files Coverage Δ
locust/env.py 96.72% <ø> (-0.11%) ⬇️
locust/main.py 21.19% <0.00%> (+1.19%) ⬆️
locust/runners.py 84.61% <ø> (+2.84%) ⬆️
locust/web.py 91.56% <ø> (+0.23%) ⬆️
locust/argument_parser.py 77.19% <100.00%> (ø)
locust/user/task.py 96.27% <0.00%> (+0.53%) ⬆️
locust/stats.py 91.09% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b2ac75...41ed113. Read the comment docs.

@cyberw
Copy link
Collaborator

cyberw commented Oct 6, 2020

Nice! But can you give an error when someone tries to use step load? Like the --slave parameter is handled atm (check main.py:129 for inspiration)

@cyberw
Copy link
Collaborator

cyberw commented Oct 12, 2020

@max-rocket-internet Any chance you'll have time to finish this soon? :)

@max-rocket-internet
Copy link
Contributor Author

@cyberw pushed changes, I think that's it 🙂

@cyberw
Copy link
Collaborator

cyberw commented Oct 12, 2020

thanks!

@cyberw cyberw merged commit bfb80da into locustio:master Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove step load feature now that LoadTestShape is possible?
2 participants