Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and fix delayed user stopping in combination with on_stop #1560

Merged
merged 5 commits into from
Sep 16, 2020
Merged

Refactor and fix delayed user stopping in combination with on_stop #1560

merged 5 commits into from
Sep 16, 2020

Commits on Sep 15, 2020

  1. Make Users aware of which gevent group they are in, instead of forcin… 

    …g callers of User.stop() specify it. Add some type hints.
    @cyberw
    cyberw committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    7671863 View commit details
    Browse the repository at this point in the history

  2. Refactor: inline _check_stop_condition. It is only ever used in three… 

    … places, and (because its main use is to throw an exception) it makes things a little hard to understand.
    @cyberw
    cyberw committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    2545786 View commit details
    Browse the repository at this point in the history

  3. Add failing test case for #1552 

    Rename a test case.
    @cyberw
    cyberw committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    46fe8c4 View commit details
    Browse the repository at this point in the history

  4. Fix #1552 by using separate greenlets to call .stop(), to allow them … 

    …to run in parallel.
    @cyberw
    cyberw committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    f6db44e View commit details
    Browse the repository at this point in the history

  5. Assert that every user actually triggered on_stop, even in special ca… 

    …ses.
    @cyberw
    cyberw committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    2c1cdcf View commit details
    Browse the repository at this point in the history