Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hatch-rate parameter deprecated instead of killing it right away. #1526

Merged

Conversation

cyberw
Copy link
Collaborator

@cyberw cyberw commented Aug 18, 2020

The renamed events are still incompatible, but that should impact much fewer users.

Should we still call it 2.0? I guess we should.

ping @lhupfeldt

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #1526 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1526      +/-   ##
==========================================
- Coverage   82.10%   82.06%   -0.04%     
==========================================
  Files          28       28              
  Lines        2509     2509              
  Branches      381      381              
==========================================
- Hits         2060     2059       -1     
- Misses        354      355       +1     
  Partials       95       95              
Impacted Files Coverage Δ
locust/argument_parser.py 77.19% <ø> (ø)
locust/main.py 20.44% <0.00%> (ø)
locust/runners.py 83.23% <0.00%> (-0.20%) ⬇️
locust/user/task.py 97.29% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bc5c5e...d00b847. Read the comment docs.

@lhupfeldt
Copy link
Contributor

How does the renamed events affect users? I'm too new to Locust to determine whether it is necessary to call it 2.0.
If you follow strict semver then any breaking change should get a new major version - but in my opinion that can also be confusing for users that will generally expect major new functionality in a new major version.

@cyberw
Copy link
Collaborator Author

cyberw commented Aug 18, 2020

I think there is enough new functionality to call it 2.0. The breaking change is that if a user listens to the hatch_complete event, they will have to change it to use spawning_complete instead (example: https://github.com/SvenskaSpel/locust-plugins/blob/8a84100bff1ecffe6164be2a9bb631c631ef11b4/locust_plugins/listeners.py#L109)

Whether we call it 1.2 or 2.0 is mostly a matter of taste I guess. Parts of the general OS community (and browser developers etc) seem to have gone the way of releasing lots of major versions (chrome is now 84.x and firefox something like 78.x :)

@lhupfeldt
Copy link
Contributor

2.0 seems fine to me.

@cyberw cyberw merged commit 207d223 into master Aug 18, 2020
@cyberw cyberw deleted the make-hatch-rate-deprecated-instead-of-killing-it-outright branch August 19, 2020 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants