Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print valid URL when --web-host is not specified #1496

Merged
merged 2 commits into from
Jul 30, 2020

Conversation

dmitrytokarev
Copy link
Contributor

Currently if --web-host option is not specified the message is:
Starting web interface at http://:8089 which is an invalid URL and may confuse new users.

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #1496 into master will increase coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
+ Coverage   81.26%   81.32%   +0.05%     
==========================================
  Files          27       27              
  Lines        2386     2388       +2     
  Branches      366      367       +1     
==========================================
+ Hits         1939     1942       +3     
- Misses        353      355       +2     
+ Partials       94       91       -3     
Impacted Files Coverage Δ
locust/main.py 18.66% <0.00%> (-0.19%) ⬇️
locust/runners.py 80.20% <0.00%> (-0.62%) ⬇️
locust/user/task.py 96.21% <0.00%> (+0.54%) ⬆️
locust/clients.py 95.09% <0.00%> (+4.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a167d2b...d3d5e53. Read the comment docs.

@heyman
Copy link
Member

heyman commented Jul 29, 2020

Saying http://127.0.0.1:8089 might mislead people to believe that the server is only accepting connections from localhost.

In the case when web_host is */'', maybe it should say something like this instead:

Starting web interface at http://127.0.0.1:8089 (accepting connections from all network interfaces)

@dmitrytokarev
Copy link
Contributor Author

@heyman I replaced 127.0.0.1 to 0.0.0.0 since . Added the note you proposed.

@heyman heyman merged commit f5b89d7 into locustio:master Jul 30, 2020
@heyman
Copy link
Member

heyman commented Jul 30, 2020

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants