Replace locust setup teardown with events #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…laced by events, since that makes much more sense)
Remove master_start_hatching, master_stop_hatching, locust_start_hatching and locust_stop_hatching because their purpose is very unclear. The documentation does not correspond to how they work, and there are no tests for them. The test_start and test_stop events should probably work as replacement in many cases, and I'm planning to add a user_count_change event that is fired on all worker nodes when users are hatched/killed.
Codecov Report
@@ Coverage Diff @@
## master #1309 +/- ##
==========================================
+ Coverage 80.21% 83.15% +2.93%
==========================================
Files 23 23
Lines 2118 2250 +132
Branches 321 389 +68
==========================================
+ Hits 1699 1871 +172
+ Misses 339 308 -31
+ Partials 80 71 -9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #1284