Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed slave to drone #1173

Closed
wants to merge 1 commit into from
Closed

Conversation

transformer11
Copy link

Motivation

Be more inclusive and support better open source practices remove the offensive term 'slave' most often used to reference human rights abuses. See previous examples of similar name changes by other leading open source projects: Python (https://bugs.python.org/issue34605), Drupal (https://www.drupal.org/node/2275877), Django (django/django#2692), Jenkins (https://issues.jenkins-ci.org/browse/JENKINS-29522) et al.

Proposed Resolution

Rename word 'slave' to 'drone' as seems to match Locust's use case. Industry recommendations for alternate terms: https://www.theserverside.com/opinion/Master-slave-terminology-alternatives-you-can-use-right-now

@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #1173 into master will increase coverage by 0.26%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1173      +/-   ##
==========================================
+ Coverage   79.26%   79.52%   +0.26%     
==========================================
  Files          20       20              
  Lines        1895     1895              
  Branches      294      294              
==========================================
+ Hits         1502     1507       +5     
+ Misses        321      315       -6     
- Partials       72       73       +1
Impacted Files Coverage Δ
locust/stats.py 85.17% <100%> (ø) ⬆️
locust/main.py 34.78% <11.11%> (ø) ⬆️
locust/web.py 88.37% <16.66%> (ø) ⬆️
locust/runners.py 81.62% <88.88%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9344ef6...c161349. Read the comment docs.

@cyberw
Copy link
Collaborator

cyberw commented Nov 28, 2019

I think "drone" would be terrible name for what is currently called a "slave". Locust terminology is confusing enough with its "clients/locusts" and "swarming". Would anyone instinctively know what is the difference between a drone and a locust, for instance?

Maybe "worker" would be ok, but right now I think we should just not change it.

@max-rocket-internet
Copy link
Contributor

I like the PR.

I think "drone" would be terrible name for what is currently called a "slave"

I think it's fine. I did a quick search but couldn't find something better. Perhaps primary/replica but that implies a different relationship. All the other options sound off to me.

Locust terminology is confusing enough with its "clients/locusts" and "swarming"

1000% this. It's very confusing.

@heyman
Copy link
Member

heyman commented Nov 28, 2019

There's an existing issue for this: #220. I've reopened it (I guess it got closed because of lack of activity).

I don't like Drone, but I think Worker would be fine.

@heyman
Copy link
Member

heyman commented Nov 28, 2019

Note that this would break a lot of backwards compatibility with existing test environments. It would be perfect to do before a 1.0 release or something, but perhaps it could be acceptable in a new 0.x release as well?

@cyberw
Copy link
Collaborator

cyberw commented Nov 28, 2019

I think we should do it as part of 1.0. I wouldnt mind doing a general clean up of terminology at the same time (favouring more standard terminology like "start" instead of "hatch", "ramp up" instead of "hatch rate" etc).

This PR also does some weird things like alter the change log. It looks a lot like just a global search-replace...

@cyberw
Copy link
Collaborator

cyberw commented Nov 28, 2019

Also, if we're going to pollute the git history/blame of pretty much every file we might as well start to do auto-formatting at the same time :)

@heyman
Copy link
Member

heyman commented Nov 28, 2019

Ok, let's do this properly for 1.0. I'll close this PR and we can continue the discussion in #220.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants