-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renamed slave to drone #1173
renamed slave to drone #1173
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
+ Coverage 79.26% 79.52% +0.26%
==========================================
Files 20 20
Lines 1895 1895
Branches 294 294
==========================================
+ Hits 1502 1507 +5
+ Misses 321 315 -6
- Partials 72 73 +1
Continue to review full report at Codecov.
|
I think "drone" would be terrible name for what is currently called a "slave". Locust terminology is confusing enough with its "clients/locusts" and "swarming". Would anyone instinctively know what is the difference between a drone and a locust, for instance? Maybe "worker" would be ok, but right now I think we should just not change it. |
I like the PR.
I think it's fine. I did a quick search but couldn't find something better. Perhaps
1000% this. It's very confusing. |
There's an existing issue for this: #220. I've reopened it (I guess it got closed because of lack of activity). I don't like |
Note that this would break a lot of backwards compatibility with existing test environments. It would be perfect to do before a 1.0 release or something, but perhaps it could be acceptable in a new 0.x release as well? |
I think we should do it as part of 1.0. I wouldnt mind doing a general clean up of terminology at the same time (favouring more standard terminology like "start" instead of "hatch", "ramp up" instead of "hatch rate" etc). This PR also does some weird things like alter the change log. It looks a lot like just a global search-replace... |
Also, if we're going to pollute the git history/blame of pretty much every file we might as well start to do auto-formatting at the same time :) |
Ok, let's do this properly for 1.0. I'll close this PR and we can continue the discussion in #220. |
Motivation
Be more inclusive and support better open source practices remove the offensive term 'slave' most often used to reference human rights abuses. See previous examples of similar name changes by other leading open source projects: Python (https://bugs.python.org/issue34605), Drupal (https://www.drupal.org/node/2275877), Django (django/django#2692), Jenkins (https://issues.jenkins-ci.org/browse/JENKINS-29522) et al.
Proposed Resolution
Rename word 'slave' to 'drone' as seems to match Locust's use case. Industry recommendations for alternate terms: https://www.theserverside.com/opinion/Master-slave-terminology-alternatives-you-can-use-right-now