optional ramping feature; sorting stats by column #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…percentile in stats.py to be used in the start_ramp function in core.py.
…nted start_ramp code start_ramp is now woking; it's ramping up exceeding a boundery then gradually getting closer, splitting the max distance in half til "hatch_stride" is lower than "precision"
… tab and Failures tab. The sorting is not rendered until the next updateStats call though (so once every 2 seconds)
"current_percentile" calculates the response time percentile for the requests in a time window. It is implemented to work in both distributed and local mode. autotune.py listens to the events on_slave_report, on_report_to_master and on_request_success and handles a deque of the latest response times TIME_WINDOW seconds back in time.
Added variable reset to start_ramping, if reset is set to true all currently spawned clients will be killed Added variable start_count; start_count is the number of clients that will be spawned before starting the ramping
…on current_percentile since all this functionality now is in autotune.py
removed <a> tag element on the labels and use the <th> instead
… when sorting by columns
fixed a check of the key "current_reponses" in data for the event on_slave_report so that the list of responsetimes is only appended if the key exists
…ponse times for being used in the start_ramping function
…is because of that the kill_locusts name fits better if the function adding clients is named spawn_locusts
Fixed so that the ramp down will never kill less than "precision" amount of clients
…forgot to refactor
… ramp functionality
… used; this to make the UI for ramp optional as well Changed "/ramp" route to fit with the ramp form in the web UI
…ge calibration times during the ramping
…his I made the start_ramping spawn in a separate greenlet added "calibration_time" to the ramp form in the interface
…fter a test has already been run (the ramp_text should only be shown on the index page when no test has yet been run)
…ad of hatch_rate) in start_ramping when spawning the initial number of clients
|
|
||
|
|
||
| if options.ramp: | ||
| import autotune |
There was a problem hiding this comment.
I think you might have forgot to commit autotune.py?
| if len(master_response_times) > slaves * response_times_per_slave_count: | ||
| master_response_times.popleft() | ||
|
|
||
| events.request_success += on_request_success |
There was a problem hiding this comment.
The setting up of the event listeners should probably be conditioned by an if block, so that the ramping stats overhead isn't activated by mistake if someone imports rampstats.
The best thing would probably be to set up the listeners in either main.py or core.py (but still keep the listener functions in rampstats.py of course).
|
Hi! I haven't had time to run the code yet, but I've went through it. Overall it's looking great. I've added line notes on a few small things that I think could be improved. Great job! |
… so now I fixed htem
The eventlistensers are only created if --ramp is used
removed unused calibration code
|
Hi! Now I think I've fixed the issues pointed out |
Changed so that RequestStats property fail_ratio is used in web.py instead of caluculating the fail ratio there
…ter/slaves when usering the --ramp option
…w only done once and the result put in a variable in rampstats.py
…ptable fail ratio Before there was a problem if the acceptable fail ratio was 0
heyman
added a commit
that referenced
this pull request
Nov 7, 2011
Optional feature for letting locust ramp up and choose number of users automatically. Sorting of stats in web UI.
cpennington
added a commit
to cpennington/locust
that referenced
this pull request
Aug 26, 2015
Precision improvements
tyge68
added a commit
to tyge68/locust
that referenced
this pull request
Sep 15, 2021
# This is the 1st commit message: locustio#1884 User distribution should happen when new workers comes in # This is the commit message locustio#2: locustio#1884 reformatting # This is the commit message locustio#3: locustio#1884 Make rebalance interval configurable # This is the commit message locustio#4: locustio#1884 Adding integration test for rebalanced # This is the commit message locustio#5: locustio#1884 revert change # This is the commit message locustio#6: locustio#1886 Simplify solution # This is the commit message locustio#7: locustio#1886 adding missing dependency # This is the commit message locustio#8: locustio#1884 Adding back enable rebalancing option # This is the commit message locustio#9: locustio#1884 adding extra comment the test # This is the commit message locustio#10: locustio#1884 renaming as suggested # This is the commit message locustio#11: locustio#1884 update help description # This is the commit message locustio#12: locustio#1884 handling of missing workers to rebalance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional ramping feature; use command line option --ramp to make ramping available in the web UI
When --ramp is used rampstats.py will gather some additional data for calculation of the current percentile. running --ramp will add additional cpu overhead on the master locust ((an append and a pop on a deque) O(n) where n is the number of slaves)
when --ramp is not run locust should not be affected by this feature
Added sorting by column on the stats headers in the UI; works on both Statistics and Failures -panes