You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think there's a compelling reason for these types to differ in their host checks.
I'm using locust against a websocket service where it also uses the FastHttpUser client: in our case we would ideally use host to point to a websocket url but FastHttpUser's stricter check disallows this whereas HttpUser would.
So I think the stricter checking should be removed entirely to bring them into parity.
Prerequisites
Description
As a followup to #1222:
FastHttpUser
has differences fromHttpUser
but is documented as a simple drop-in replacement for most cases. The fix for #1222 (#1227) was intended to relaxFastHttpUser
's host checking to be in line withHttpUser
's however there's still a major difference between them:HttpUser
doesn't validate the host url format, only ensuring it's notNone
:https://github.com/locustio/locust/blob/68ffae8/locust/user/users.py#L252
I don't think there's a compelling reason for these types to differ in their host checks.
I'm using locust against a websocket service where it also uses the
FastHttpUser
client: in our case we would ideally usehost
to point to a websocket url butFastHttpUser
's stricter check disallows this whereasHttpUser
would.So I think the stricter checking should be removed entirely to bring them into parity.
Command line
locust -f locustfiles/locustfile.py --websocket_url ws://localhost:9150
Locustfile contents
Python version
3.10
Locust version
2.19.1
Operating system
Linux
The text was updated successfully, but these errors were encountered: