Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version information in Docker image is incorrect #1885

Closed
MaggotMouth opened this issue Sep 15, 2021 · 5 comments
Closed

Version information in Docker image is incorrect #1885

MaggotMouth opened this issue Sep 15, 2021 · 5 comments
Labels
bug

Comments

@MaggotMouth
Copy link

Describe the bug

When running the docker image after v2.1.0, the version reported by locust is incorrrect

Expected behavior

From 2.1.0 image:

$ locust --version
locust 2.1.0

Actual behavior

$ locust --version
locust 0.1.dev1

Steps to reproduce

See above.
Expect it was introduced in #1847

Environment

  • OS: docker
  • Locust version: > 2.1.0 - including masterr
  • Locust command line that you ran: locust version
@cyberw
Copy link
Collaborator

cyberw commented Sep 15, 2021

Thanks for reporting. It is fixed now (mainly in 78efcf7), I just have to make a release...

@cyberw cyberw changed the title Version information incorrect Version information in Docker image is incorrect Sep 15, 2021
@cyberw cyberw closed this as completed Sep 15, 2021
@MaggotMouth
Copy link
Author

Thanks for the quick action @cyberw

Just want to confirm that after pulling the newest docker image, this is now the response:

$ locust --version
locust 2.2.3.dev0

Not sure if that dev0 should be there 🤷

@MaggotMouth
Copy link
Author

Also, that's from the 2.2.2 docker image, not 2.2.3 (which doesnt exist, obviously)

@cyberw
Copy link
Collaborator

cyberw commented Sep 15, 2021

Huh. That's weird. It shouldnt be there. I'll try again to fix it.

cyberw added a commit that referenced this issue Sep 15, 2021
@cyberw
Ignoring docs from docker build context made git think there were loc…
2523a84 
…al changes (and thus bumping the version number).

docs/_build are the only files big enough to care about (and they are excluded from git, in .gitignore)

Should fix #1885 properly, I hope.
@cyberw
Copy link
Collaborator

cyberw commented Sep 16, 2021

Should be fixed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cyberw @MaggotMouth