-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): support excel metadata files in data upload form #3469
Conversation
|
TODO: Testing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Felix, this looks great to me! I tested it with for WNV using data that I just uploaded to #3469. Below are a few minor comments.
The preview seems messed up at the moment - I can't log in (I'm sure that's not to do with the changes you've made just some weird state thing, or pre-existing bug) |
I made an empty commit to try and trigger a redeployment of the preview, I also see the error you're seeing. I can' imagine that the changes I have made are somehow responsible. |
When you rebase it should be fixed :) |
I rebased, it works! I'm getting started on the compression handling, I found a lib, looks like it should be easy to implement |
handling compression is in fact not easy, it was a pain. but I think it should work now, the tests passed locally. |
the lzma lib needs to be swapped out as well. |
Sorry for the pain - yes in fairness I'd forgotten how many different methods we support :( |
no worries 😄 I thought "surely there's a a just unpack it lib" - I have used commandline tools that do that before. But alas, I couldn't find one. And then some of the libs are quite old, I had to try out a few different ones before finding ones that work well and have type support etc. But now it looks like it's working! (EDIT: Shit, test failed again) |
Ok, so this library that I used for xz (xz-decompress) also has some issues, because vite thinks it's commonJS and it's wonky to import. Now I also found this: https://www.npmjs.com/package/libarchive.js but it requires a custom I have to continue this tomorrow. Why are all the xz/lzma libs so weird to use? 😢 Alternatively, we just defer this (who would upload xz compressed excel files?!) and just add a popup that that file combination doesn't work yet and that's that. I don't feel like it's really worth spending a lot of time on this. |
👍 |
Agree, this sounds good to me! |
website/src/components/Submission/FileUpload/UploadComponent.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, works for me!
resolves #3334
preview URL: https://excel-upload.loculus.org
Summary
Screenshot
PR Checklist
All necessary documentation has been adapted.