Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1072 implement request ids to trace errors #3005

Merged
merged 3 commits into from
Oct 28, 2024
Merged

1072 implement request ids to trace errors #3005

merged 3 commits into from
Oct 28, 2024

Conversation

fengelniederhammer
Copy link
Contributor

@fengelniederhammer fengelniederhammer commented Oct 15, 2024 •
edited
Loading

resolves #1072

preview URL: https://1072-implement-request-id.loculus.org/

Summary

I didn't know how to implement it in the website. Having "request scoped objects" in the Astro server-side code is difficult. But it would be good to also have it there. An idea would be using a middleware to store it in context.locals. Then one could retrieve it via Astro.locals, but that works only in .astro files. Usually we need it in .ts files.

Screenshot

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@fengelniederhammer fengelniederhammer added the preview Triggers a deployment to argocd label Oct 15, 2024
@fengelniederhammer fengelniederhammer force-pushed the 1072-implement-request-ids-to-trace-errors branch from 69d9e39 to 8794dfa Compare October 15, 2024 12:18
anna-parker
anna-parker approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@anna-parker anna-parker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a kotlin expert but I looked over this with the help of chatGPT and it looks good! I also checked the logs and there is indeed a new UID:
which can be used for tracking logs from the request:
image

@fengelniederhammer fengelniederhammer force-pushed the 1072-implement-request-ids-to-trace-errors branch from 8794dfa to 348b79a Compare October 28, 2024 08:04
@fengelniederhammer fengelniederhammer merged commit 6eb8366 into main Oct 28, 2024
23 checks passed
@fengelniederhammer fengelniederhammer deleted the 1072-implement-request-ids-to-trace-errors branch October 28, 2024 09:02
@corneliusroemer corneliusroemer mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anna-parker anna-parker anna-parker approved these changes

Assignees
No one assigned
Labels
preview Triggers a deployment to argocd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement request IDs to trace errors
2 participants
@fengelniederhammer @anna-parker