Make projection list accessible #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michele Noberasco <[email protected]>
Signed-off-by: Michele Noberasco <[email protected]>
Signed-off-by: Michele Noberasco <[email protected]>
noberasco
force-pushed
the
projection_list
branch
from
8ec4407
to
477cd56
Compare
echeipesh
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method getProjection() in class Registry allows to obtain an instance of Projection given its name.
Internally, Registry maintains an internal list of Projections names <-> classes mappings and creates an instance of the correct class.
This pull request adds a method to retrieve a complete list of all usable Projection instances.
NOTE: if you run the code you will discover that there are 3 projections configured in Registry that cannot be allocated:
They should probably be commented out in initialize() until they are property implemented (they point to class Projection, which is abstract and cannot be instanced).
The code in my pull request handles gracefully these non-instanceable projections.