Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #107

Merged
merged 2 commits into from
Dec 24, 2023
Merged

Update README.md #107

merged 2 commits into from
Dec 24, 2023

Conversation

samuelcregan17
Copy link
Contributor

While trying to use this library in a Gradle project, I was running into the error "Unable to access CRS file: proj4/nad/epsg". I noticed the note for Maven projects to add the epsg dependency, so tried adding it to my Gradle dependencies and it solved the problem.

While trying to use this library in a Gradle project, I was running into the error "Unable to access CRS file: proj4/nad/epsg". I noticed the note for Maven projects to add the epsg dependency, so tried adding it to my Gradle dependencies and it solved the problem.
@pomadchin
Copy link
Member

Hi @samuelcregan17, could you sign ECA to make Eclipse ECA Validator happy?

Also wondering, could you refactor it to make it looks similar to the maven description? https://github.com/locationtech/proj4j?tab=readme-ov-file#proj4j-epsg

Make Gradle section similar to Maven section
@samuelcregan17
Copy link
Contributor Author

@pomadchin I signed the ECA and made those changes. Is this what you had in mind?

@pomadchin
Copy link
Member

@samuelcregan17 thanks!

Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 with your first contribution!

@pomadchin pomadchin merged commit 8f61332 into locationtech:master Dec 24, 2023
2 checks passed
@samuelcregan17 samuelcregan17 deleted the patch-1 branch December 26, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants