ConstantTile with NoData: support idempotent CellType conversions #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
changed the title
pomadchin
commented
Oct 28, 2024
Comment on lines
85
to
92
| case BitCellType => new BitConstantTile(if (iVal == 0) false else true, cols, rows) | ||
| case ct: ByteCells => ByteConstantTile(iVal.toByte, cols, rows, ct) | ||
| case ct: ByteCells => ByteConstantTile(i2b(iVal), cols, rows, ct) | ||
| case ct: UByteCells => UByteConstantTile(iVal.toByte, cols, rows, ct) | ||
| case ct: ShortCells => ShortConstantTile(iVal.toShort , cols, rows, ct) | ||
| case ct: UShortCells => UShortConstantTile(iVal.toShort , cols, rows, ct) | ||
| case ct: IntCells => IntConstantTile(iVal , cols, rows, ct) | ||
| case ct: FloatCells => FloatConstantTile(dVal.toFloat , cols, rows, ct) | ||
| case ct: ShortCells => ShortConstantTile(i2s(iVal), cols, rows, ct) | ||
| case ct: UShortCells => UShortConstantTile(i2us(iVal) , cols, rows, ct) | ||
| case ct: IntCells => IntConstantTile(iVal, cols, rows, ct) | ||
| case ct: FloatCells => FloatConstantTile(d2f(dVal), cols, rows, ct) | ||
| case ct: DoubleCells => DoubleConstantTile(dVal, cols, rows, ct) |
There was a problem hiding this comment.
That's the bug actually^ a tiny gotcha that caused this bug.
i.e. Int.MinValue.toByte / .toShort does not return us an expected NoDataValue:
Int.MinValue.toByte //> 0
Int.MinValue.toShort //> 0
pomadchin
changed the title
5 tasks
pomadchin
force-pushed
the
fix/constant-tile-conversions
branch
from
977459b
to
d98a9ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes ConstantCellType conversions of the Byte and Short CellTypes as well as adds the ConstantTile.empty constructor.
Fixes #3525
Supersedes & closes #3552
cc @jdries