Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix numerical errors #3520

Closed
wants to merge 5 commits into from
Closed

Fix numerical errors #3520

wants to merge 5 commits into from

Commits on Sep 8, 2023

  1. apply rounding/flooring consistently

    @jdries
    jdries authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    bb49512 View commit details
    Browse the repository at this point in the history

  2. fix wrong offset due to limited numerical precision 

    values like 4.9999999999 were actually floored to 4, whereas it should be 5, caused pixel shifts in output
    @jdries
    jdries authored Sep 8, 2023
    Configuration menu
    Copy the full SHA
    8f24742 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2023

  1. add unit test

    @jdries
    jdries committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    0e29b38 View commit details
    Browse the repository at this point in the history

  2. replace asserts

    @jdries
    jdries committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    63b1615 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into grid_flooring

    @jdries
    jdries committed Sep 10, 2023
    Configuration menu
    Copy the full SHA
    6fbe7aa View commit details
    Browse the repository at this point in the history