Add JDK11 cross compilation #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pomadchin
force-pushed
the
feature/jdk11
branch
from
d0f3c75
to
748493d
Compare
github-test-jdk11-1 | [info] *** 2 TESTS FAILED ***
github-test-jdk11-1 | [error] Failed: Total 1533, Failed 2, Errors 0, Passed 1531
github-test-jdk11-1 | [error] Failed tests:
github-test-jdk11-1 | [error] geotrellis.raster.reproject.ReprojectSpec
github-test-jdk11-1 | [error] geotrellis.raster.render.png.RenderPngTests |
|
This may be complicated by nextgenhealthcare/connect#4422 and https://issues.apache.org/jira/browse/SPARK-37843 |
pomadchin
commented
Sep 14, 2023
| @@ -339,7 +339,7 @@ class RenderPngTests extends AnyFunSuite with Matchers with TileBuilders with Ra | |||
| val stops = Array(10000, 20000, 30000, 40000, 50000, 60000, 70000) | |||
| val colorMap = ColorMap(stops, ramp) | |||
|
|
|||
| val greyPng = colorMap.render(tile).map(z => z >> 8 & 0xFF).renderPng(GreyPngEncoding(0x00)) | |||
| val greyPng = colorMap.render(tile).map(z => z >> 8 & 0xFF).renderPng(GreyPngEncoding) | |||
There was a problem hiding this comment.
Good question why it worked, technically it was written as an greya image with colorType set to 0 in header that could be considered by some readers as grey (header) and by others as greya (header + the data structure).
JDK 11 ImageIO added some heuristics to convert grey into greya based on the actual data written not only based on the header info ¯\_(ツ)_/¯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds CI test that run tests against JDK11. Mb to do a total switch to JDK11 with the target pointing to 1.8?
Checklist
Closes #3301