-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace geowave subproject with GeoTrellis/GeoWave data adapter #3364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echeipesh
force-pushed
the
geowave-adapter
branch
4 times, most recently
from
April 8, 2021 14:10
7fc4a7c
to
d8bbe70
Compare
This version is used by GeoMesa and doesn't cause BI problems with GeoWave.
pomadchin
force-pushed
the
geowave-adapter
branch
from
April 29, 2021 22:25
d8bbe70
to
1442008
Compare
pomadchin
force-pushed
the
geowave-adapter
branch
2 times, most recently
from
April 30, 2021 00:25
4981b3e
to
23e7da6
Compare
…tation from benchmarks, generate missing headers
pomadchin
force-pushed
the
geowave-adapter
branch
from
April 30, 2021 00:26
23e7da6
to
8241774
Compare
pomadchin
force-pushed
the
geowave-adapter
branch
from
April 30, 2021 02:10
536ecb9
to
4d791cb
Compare
pomadchin
force-pushed
the
geowave-adapter
branch
from
April 30, 2021 02:29
8ff9947
to
c18f6ee
Compare
pomadchin
force-pushed
the
geowave-adapter
branch
from
April 30, 2021 03:02
3fc7253
to
b904c03
Compare
pomadchin
force-pushed
the
geowave-adapter
branch
from
April 30, 2021 04:03
b904c03
to
90e9007
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR majorly revamps
geowave
package.Previous approach was to implement a GeoTrellis layer reader/writer and attribute store interface that is backed by GeoWave tables. This was neat but ultimately the GeoTrellis query interface is limited in types of queries that it can express and results it can generate. When wishing to store records indexed by 3+ dimensions, possibly rasters, the GeoTools DataStore interface and CQL provides better interface.
This PR implements
GeoTrellisDataAdapter
as GeoWaveDataAdapter, along with field reader/writer for GeoTrellis raster values. To some extent this is Scala friendly extension of normal GeoWave adapter/index type hierarchy. The fields writers provider are suitable for any types already using theAvroCodecs
used by GeoTrellis. Note that the field handler mechanics for theGeoTrellisDataAdapter
differ from GeoWave'sAbstractDataAdapter
.. this is intentional and was done with aim of clarity of implementation for the Scala client.Additionally this PR adds the field definition for "Elevation" dimension and couple of index implementations to address the underlying use-case of querying volumetric data over time. This may eventually migrate to either client code or could be contributed in GeoWave project with a little more discussion.
Because the GeoWave support was considered experimental and lightly (if at all) used, this change can escape major version bump.
geowave
module should still be considered experimental. Future work may include introduction of type-safe query interface and GeoWave index builder.Dependencies
(these libraries upgrade happened here #3341)
CQs
Checklist
docs
guides update, if necessary