Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor spire dependency to support using different versions between scala versions #3357

Closed

Conversation

philvarner
Copy link
Contributor

Signed-off-by: philvarner [email protected]

Overview

  1. Different versions of spire have different groupIds. org.spire-math %% spire % 0.13 is only available for 2.11 and 2.12, and org.typelevel %% spire % 0.17 is only available for 2.12 and 2.13. This changes allows those different versions to be expressed.
  2. It also extends ver to support a different dependency version for 2.13.
  3. removes some stray whitespace

Checklist

  • ./CHANGELOG.md updated, if necessary. Link to the issue if closed, otherwise the PR.
  • Module Hierarchy updated, if necessary
  • docs guides update, if necessary
  • New user API has useful Scaladoc strings
  • Unit tests added for bug-fix or new feature

Demo

none

Notes

none

@pomadchin pomadchin self-requested a review March 11, 2021 15:49
@pomadchin
Copy link
Member

Let's do this upgrade in terms of the Spark 3 migration #3218
Anyway, Spark 2 is incompatible with spire 0.17.

@pomadchin pomadchin closed this Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants