Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gdal-warp-bindings v1.1.1 #3303

Merged
merged 3 commits into from
Nov 23, 2020
Merged

Update gdal-warp-bindings v1.1.1 #3303

merged 3 commits into from
Nov 23, 2020

Conversation

CloudNiner
Copy link
Contributor

@CloudNiner CloudNiner commented Nov 13, 2020 •
edited by pomadchin
Loading

Overview

Updates gdal-warp-bindings to the newly released 1.1.1 to address MacOS dylib issues.

Checklist

  • ./CHANGELOG.md updated, if necessary. Link to the issue if closed, otherwise the PR.
  • GDALWarp bindings 1.1.1 CQ #22803

pomadchin
pomadchin approved these changes Nov 14, 2020
View reviewed changes
Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works wonderful! Tests passed for me with the local brew GDAL 3.2.0 installed and symlinked to match the GDAL 3.1.x dylib version: ln -s /usr/local/lib/libgdal.28.dylib /usr/local/lib/libgdal.27.dylib

I left a minor comment about the CHANGELOG. And we need to file a CQ before merging it!

CHANGELOG.md Outdated Show resolved Hide resolved
@CloudNiner
Copy link
Contributor Author

CQ Approved!

@CloudNiner
Copy link
Contributor Author

Going to await testing by @moradology before merge.

@pomadchin pomadchin added this to the Sprint 11/13 - 12/3/2020 milestone Nov 19, 2020
@pomadchin
Copy link
Member

pomadchin commented Nov 19, 2020 •
edited
Loading

I merged in #3295 and it created CHANGELOG conflicts. I resolved them though the Web UI and that is what 02839d8 about.

@CloudNiner
Copy link
Contributor Author

👍

@pomadchin
Copy link
Member

pomadchin commented Nov 23, 2020 •
edited
Loading

How about merging it in and rising a new issue if it would happen to be the case? We'd anyway have to publish a GDAL 3.2.x release soonish => there would definitely be a chance to return back to it. I'd like to get this PR into the upcoming release.

cc @moradology @CloudNiner @notthatbreezy

@CloudNiner CloudNiner merged commit c0baa51 into master Nov 23, 2020
@CloudNiner CloudNiner deleted the feature/awf/gdal-warp-bindings-1.1.1 branch November 23, 2020 18:03
@pomadchin pomadchin mentioned this pull request Oct 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomadchin pomadchin pomadchin approved these changes

@moradology moradology Awaiting requested review from moradology

Assignees

@moradology moradology

Labels
None yet
Projects
None yet
Milestone
Sprint 11/13 - 12/3/2020
Development

Successfully merging this pull request may close these issues.
3 participants
@CloudNiner @pomadchin @moradology