Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ScalaPB version up #2898

Merged
merged 6 commits into from
Apr 26, 2019
Merged

Bump ScalaPB version up #2898

merged 6 commits into from
Apr 26, 2019

Conversation

pomadchin
Copy link
Member

@pomadchin pomadchin commented Apr 12, 2019 •
edited
Loading

Overview

This PR updates scalapb deps in the vectortile project, removes all generated files from the src folder, starting from this point everything would be generated from this .proto schema on each fresh compilation.

Checklist

  • docs guides update, if necessary
  • protobuf-java 3.7.0 # CQ 19573
  • scalapb-runtime 0.9.0-RC1 # CQ 19574
  • fastparse 1.0.0 # 19575
  • sourcecode 0.1.4 # 19578

Fixes #2909

@pomadchin pomadchin changed the title Update ScalaPB version Bump ScalaPB version up Apr 12, 2019
@pomadchin pomadchin added this to the 3.0 milestone Apr 22, 2019
@pomadchin pomadchin mentioned this pull request Apr 25, 2019
Closed
@pomadchin pomadchin requested a review from jpolchlo April 25, 2019 18:15
CloudNiner
CloudNiner approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@CloudNiner CloudNiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normalize changes look fine to me, pending a docstring tweak to explain why the normalize parameter exists.

vectortile/src/main/scala/geotrellis/vectortile/Layer.scala Outdated Show resolved Hide resolved
vectortile/src/main/scala/geotrellis/vectortile/VectorTile.scala Outdated Show resolved Hide resolved
vectortile/src/main/scala/geotrellis/vectortile/package.scala Outdated Show resolved Hide resolved
@CloudNiner
Copy link
Contributor

👍

@pomadchin
Changed normalized flag name, optimized the code, removed unused code…
38b70c8 
…, added docstring and parameter into VectorTile constructor functions.
@pomadchin pomadchin merged commit 9fbe88a into locationtech:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpolchlo jpolchlo jpolchlo left review comments

@CloudNiner CloudNiner CloudNiner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
GT 3.0
Development

Successfully merging this pull request may close these issues.

VectorTile should support option for allowing the user to choose ring winding order
3 participants
@pomadchin @CloudNiner @jpolchlo