S3InputFormat - bucket names support period and dashes #2133
Conversation
|
Just noticed ConfigFormats in spark-etl has the same problem. One option would be to change these to use http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/s3/AmazonS3URI.html |
|
Thanks for the contribution! Appreciate the consideration about alternate solutions, but I think the approach you took is the most simple and sound. Can you sign a Eclipse Committer Agreement? The instructions to do so are here: http://geotrellis.readthedocs.io/en/latest/contributing.html#eclipse-contributor-agreement-eca. Let me know if you have any questions! |
|
Done. Do I need to do anything to re-trigger the ECA check on the PR?
…On Mon, Apr 10, 2017 at 9:50 PM, Rob Emanuele ***@***.***> wrote:
Thanks for the contribution! Appreciate the consideration about alternate
solutions, but I think the approach you took is the most simple and sound.
Can you sign a Eclipse Committer Agreement? The instructions to do so are
here: http://geotrellis.readthedocs.io/en/latest/contributing.
html#eclipse-contributor-agreement-eca.
Let me know if you have any questions!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2133 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AK-MrnpPEKoiPHqguwJkodtuBQDnE67tks5ruup3gaJpZM4M34fD>
.
|
|
No, the validation is being strange so it is failing everyone. The other thing that's a bit more annoying is that Eclipse needs contributors to do a "sign-off" on the commits; it's described second paragraph here: http://geotrellis.readthedocs.io/en/latest/contributing.html#pull-requests. Can you add the sign offs on the commits? After that I'm 👍 to merge |
|
added sign offs to commits
…On Mon, Apr 10, 2017 at 10:05 PM, Rob Emanuele ***@***.***> wrote:
No, the validation is being strange so it is failing everyone.
The other thing that's a bit more annoying is that Eclipse needs
contributors to do a "sign-off" on the commits; it's described second
paragraph here: http://geotrellis.readthedocs.io/en/latest/contributing.
html#pull-requests.
Can you add the sign offs on the commits? After that I'm 👍 to merge
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2133 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AK-MrgIwXmSiHY-kBRWek8vmQgYRBVRdks5ruu3xgaJpZM4M34fD>
.
|
|
@ehochmuth oh; sign off means |
Signed-off-by: Erich Hochmuth <[email protected]>
Signed-off-by: Erich Hochmuth <[email protected]>
|
Ok rebased and ran git commit -s -S --amend -m "Author: Erich Hochmuth" for
both commits and then git push origin master --force
…On Tue, Apr 11, 2017 at 12:25 AM, Grisha ***@***.***> wrote:
@ehochmuth <https://github.com/ehochmuth> oh; sign off means sign off
header, like in this
<2b62725>
commit. It can be achieved by using -s flag: git commit -s -m "msg".
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2133 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AK-MrnyAgZNrFKqTYixERxY4ugdKx4NWks5ruw66gaJpZM4M34fD>
.
|
|
Perfect, thank you! |
Fixes #2133