Fix Non-Point Pixel + Partial Cell Rasterizer Bug #1804
Conversation
|
@zaikin Thanks for the bug report. These changes fix the broken test that you provided. Would you mind testing these changes to see if they fix your original issue? |
|
@jamesmcclain yes, it works. Thx 🎉 |
|
Sounds great. Thanks again for the bug report! |
|
@zaikin in order for us to use the commit with the unit tests, we'd need you to sign a CLA (as described in our contributing.md), and re-do that commit with an email that is associated with your github account. Would you be able to do these couple of things? Sorry for the hassle, and thanks for the bug report and contribution! Also, on mending the commit, if you could "sign" the commit (option -s), that would be ideal. |
|
@lossyrob no problem, i'll do it a bit later today. |
|
@zaikin thanks! I'm looking to push an RC out today, so if you all that done today, I'll be able to include it in the RC. |
Signed-off-by: Alexandr Zaikin <[email protected]>
|
@lossyrob i redid commit and sent a signed CLA. |
|
Rebasing now. |
The issue was that when there were edges which crossed a pixel but whose intersection with the scan rectangle was outside of that pixel, the pixel was not being reported.
jamesmcclain
force-pushed
the
fix/rasterizer
branch
from
9ff5c7c
to
f6a6752
Compare
|
Rebased. |
|
@zaikin many thanks! +1 after travis |
The issue was that when there were edges which crossed a pixel but whose intersection with the scan rectangle was outside of that pixel, the pixel was not being reported.
Supersedes #1800
Connects #1801